Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Upgrade isort pre-commit hooks. #687

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Feb 9, 2022

Motivation

Our isort hook is outdated, use new version isort hook.

Modification

As the title.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu February 9, 2022 03:51
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #687 (c61c078) into dev (bca695b) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #687   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files         120      120           
  Lines        7362     7362           
  Branches     1271     1271           
=======================================
  Hits         6259     6259           
  Misses        915      915           
  Partials      188      188           
Flag Coverage Δ
unittests 85.01% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/train.py 19.17% <0.00%> (ø)
mmcls/core/optimizers/__init__.py 100.00% <ø> (ø)
mmcls/core/visualization/__init__.py 100.00% <ø> (ø)
mmcls/core/visualization/image.py 86.32% <ø> (ø)
mmcls/models/backbones/conformer.py 98.18% <ø> (ø)
mmcls/models/backbones/repvgg.py 96.84% <ø> (ø)
mmcls/models/utils/augment/utils.py 100.00% <ø> (ø)
mmcls/datasets/builder.py 90.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca695b...c61c078. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit fcd5791 into open-mmlab:dev Feb 16, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Use new version flake8 and isort hooks

* Fix missing copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants