Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build_runner #54

Merged
merged 13 commits into from
Oct 15, 2020
Merged

Use build_runner #54

merged 13 commits into from
Oct 15, 2020

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Oct 2, 2020

No description provided.

@hellock hellock self-requested a review October 10, 2020 02:23
mmcls/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
docs/tutorials/finetune.md Outdated Show resolved Hide resolved
mmcls/apis/train.py Outdated Show resolved Hide resolved
@daavoo daavoo requested a review from hellock October 13, 2020 11:19
@ycxioooong
Copy link
Contributor

Hi @daavoo, since we have merged a new PR(#61) that adds linting into the workflow, so it infects your current code. Could you please pull the latest code to your forked repo and recommit? I think it will fix lint failure.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #54 into master will increase coverage by 4.91%.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   62.73%   67.65%   +4.91%     
==========================================
  Files          71       71              
  Lines        3059     3082      +23     
  Branches      558      562       +4     
==========================================
+ Hits         1919     2085     +166     
+ Misses       1097      949     -148     
- Partials       43       48       +5     
Flag Coverage Δ
#unittests 67.65% <75.86%> (+4.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/train.py 21.15% <25.00%> (+21.15%) ⬆️
mmcls/core/evaluation/eval_hooks.py 89.09% <95.23%> (+89.09%) ⬆️
mmcls/core/fp16/decorators.py 10.00% <0.00%> (+10.00%) ⬆️
mmcls/utils/collect_env.py 22.72% <0.00%> (+22.72%) ⬆️
mmcls/apis/inference.py 23.07% <0.00%> (+23.07%) ⬆️
mmcls/core/utils/dist_utils.py 23.07% <0.00%> (+23.07%) ⬆️
mmcls/core/fp16/hooks.py 25.00% <0.00%> (+25.00%) ⬆️
mmcls/core/fp16/utils.py 26.66% <0.00%> (+26.66%) ⬆️
mmcls/apis/test.py 28.57% <0.00%> (+28.57%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a916f...9406f34. Read the comment docs.

@daavoo
Copy link
Contributor Author

daavoo commented Oct 15, 2020

Hi @daavoo, since we have merged a new PR(#61) that adds linting into the workflow, so it infects your current code. Could you please pull the latest code to your forked repo and recommit? I think it will fix lint failure.

Fixed. Thanks!

@ycxioooong ycxioooong merged commit 4f4f295 into open-mmlab:master Oct 15, 2020
@daavoo daavoo deleted the use-build-runner branch October 19, 2020 08:02
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Use build_runner in train api

* Support iter in eval_hook

* Add runner section

* Add test_eval_hook

* Pin mmcv version in install docs

* Replace max_iters with max_epochs

* Set by_epoch=True as default

* Remove trailing space

* Replace DeprecationWarning with UserWarning

* pre-commit

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants