Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bug in 1-benchmark_valid.py if checkpoint_root is None. #489

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Oct 15, 2021

Motivation

In 1-benchmark_valid.py, if args.checkpoint_root is None, it will raise an error.

Modification

Fix the bug.

BC-breaking (Optional)

No

Use cases (Optional)

No

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 added the Bug:P2 label Oct 15, 2021
@mzr1996 mzr1996 requested a review from Ezra-Yu October 15, 2021 09:29
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #489 (57068c2) into master (63a2211) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files         102      102           
  Lines        5619     5619           
  Branches      923      923           
=======================================
  Hits         4381     4381           
  Misses       1111     1111           
  Partials      127      127           
Flag Coverage Δ
unittests 77.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/inference.py 19.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a2211...57068c2. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 08bf04e into open-mmlab:master Oct 25, 2021
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
@mzr1996 mzr1996 deleted the fix-benchmark branch December 7, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants