Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Add Opencv backend support for Visualizer #2283

Merged
merged 5 commits into from
Apr 23, 2023

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.25 ⚠️

Comparison is base (896e9d5) 82.25% compared to head (4e56526) 82.00%.

❗ Current head 4e56526 differs from pull request most recent head 24b8059. Consider uploading reports for the commit 24b8059 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2283      +/-   ##
===========================================
- Coverage    82.25%   82.00%   -0.25%     
===========================================
  Files          228      230       +2     
  Lines        13387    13613     +226     
  Branches      2268     2313      +45     
===========================================
+ Hits         11011    11163     +152     
- Misses        1862     1913      +51     
- Partials       514      537      +23     
Flag Coverage Δ
unittests 82.00% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis Ben-Louis marked this pull request as ready for review April 23, 2023 03:40
@Ben-Louis Ben-Louis requested a review from Tau-J April 23, 2023 03:40
Copy link
Collaborator

@Tau-J Tau-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tau-J Tau-J merged commit 4faa004 into open-mmlab:dev-1.x Apr 23, 2023
Tau-J pushed a commit to Tau-J/mmpose that referenced this pull request Apr 25, 2023
Tau-J pushed a commit to Tau-J/mmpose that referenced this pull request Apr 25, 2023
@Ben-Louis Ben-Louis deleted the fix-visualizer-backend branch April 26, 2023 18:00
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants