Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Detect intersection before using shapley.intersection to eliminate spurious warnings #1710

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

gaotongxiao
Copy link
Collaborator

Motivation

shapely raises a warning when users try to get the intersection of two non-overlapping polygons, resulting in overwhelming warnings in the first few training iterations when the text detection model cannot generate correct predictions and the metric tries to compute IoU between them and gts.

Close #1674

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 88.32% // Head: 88.32% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fcf8422) compared to base (2a2cab3).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head fcf8422 differs from pull request most recent head 7ade459. Consider uploading reports for the commit 7ade459 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1710   +/-   ##
========================================
  Coverage    88.32%   88.32%           
========================================
  Files          175      175           
  Lines        10896    10898    +2     
  Branches      1527     1528    +1     
========================================
+ Hits          9624     9626    +2     
  Misses         992      992           
  Partials       280      280           
Flag Coverage Δ
unittests 88.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/utils/polygon_utils.py 97.53% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit d8e6159 into open-mmlab:dev-1.x Feb 8, 2023
@gaotongxiao gaotongxiao deleted the fix_warning branch February 8, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants