Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Discard deprecated lmdb dataset format and only support img+label now #1681

Merged
merged 9 commits into from
Jan 17, 2023

Conversation

gaotongxiao
Copy link
Collaborator

No description provided.

@Harold-lkk Harold-lkk marked this pull request as ready for review January 16, 2023 09:09
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 85.79% // Head: 85.70% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (4d4dc34) compared to base (b64565c).
Patch coverage: 86.20% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1681      +/-   ##
===========================================
- Coverage    85.79%   85.70%   -0.10%     
===========================================
  Files          173      173              
  Lines        10919    10863      -56     
  Branches      1529     1519      -10     
===========================================
- Hits          9368     9310      -58     
- Misses        1285     1288       +3     
+ Partials       266      265       -1     
Flag Coverage Δ
unittests 85.70% <86.20%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/datasets/transforms/loading.py 89.51% <ø> (-1.80%) ⬇️
mmocr/datasets/recog_lmdb_dataset.py 82.00% <86.20%> (-10.31%) ⬇️
...r/models/kie/postprocessors/sdmgr_postprocessor.py 91.17% <0.00%> (-2.95%) ⬇️
mmocr/datasets/transforms/textdet_transforms.py 91.76% <0.00%> (-0.29%) ⬇️
mmocr/datasets/transforms/textrecog_transforms.py 97.33% <0.00%> (+1.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit 6992923 into open-mmlab:dev-1.x Jan 17, 2023
@gaotongxiao gaotongxiao deleted the lmdb2 branch January 17, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants