-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] TextRecogCropConverter add crop with opencv warpPersepective function #1667
Merged
gaotongxiao
merged 4 commits into
open-mmlab:dev-1.x
from
KevinNuNu:kevinnunu/TextRecogCropConverter_add_crop_with_opencv_warpPersepective
Feb 3, 2023
Merged
[Feature] TextRecogCropConverter add crop with opencv warpPersepective function #1667
gaotongxiao
merged 4 commits into
open-mmlab:dev-1.x
from
KevinNuNu:kevinnunu/TextRecogCropConverter_add_crop_with_opencv_warpPersepective
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaotongxiao
reviewed
Jan 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature!
Comment on lines
583
to
586
if 'box' in instance: | ||
return bbox2poly(instance['box']).tolist() | ||
if 'poly' in instance: | ||
return instance['poly'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if 'box' in instance: | |
return bbox2poly(instance['box']).tolist() | |
if 'poly' in instance: | |
return instance['poly'] | |
if 'poly' in instance: | |
return instance['poly'] | |
if 'box' in instance: | |
return bbox2poly(instance['box']).tolist() |
box is just a rough approximation of polygon, so polygon should be the first choice
…_with_opencv_warpPersepective
gaotongxiao
reviewed
Feb 3, 2023
gaotongxiao
approved these changes
Feb 3, 2023
KevinNuNu
deleted the
kevinnunu/TextRecogCropConverter_add_crop_with_opencv_warpPersepective
branch
February 4, 2023 12:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e function.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
自定义数据集中会有一些由于拍摄角度以及透视等问题造成的文字区域倾斜或者旋转,在标注时会用到polygon的标注方式。同时密集文本场景,不适合将polygon标注转换为水平文本框进行裁剪,需要用opencv warpPersepective方法进行裁剪
Modification
1.优化TextRecogCropConverter的pack_instance()方法,增加crop_with_warp选择按钮,引入mmocr/utils/img_utils.py中的warp_img方法,完成四边形标注的旋转文本区域的裁剪功能
2.完善了一下相应的使用文档:docs/zh_cn/user_guides/data_prepare/dataset_preparer.md
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: