Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1.x some doc mistakes #1630

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Dev 1.x some doc mistakes #1630

merged 4 commits into from
Dec 16, 2022

Conversation

KevinNuNu
Copy link
Contributor

Modification

Some doc mistakes in user_guiders markdown file:
1.dataset_prepare.md , config path to icdar2015.py was wrong
2.dataset_prepare.md , icdar2015's config content was wrong
3.visualization.md, default_runtime.py Visualization's param is visualizer not Visualizer

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

@gaotongxiao
Copy link
Collaborator

Hi, thanks for your contribution! Before we are able to merge your PR, please don't forget to sign CLA here :)

image

Also, if you get an error message like "xxx seems not to be a GitHub user", it means that the email you used to commit changes does not match the one you used in your GitHub account. You can try to link your local email to your GitHub, or update your local email address and then amend your commits:

git config --global user.email "YOUR_GITHUB_EMAIL"
git commit --amend

@KevinNuNu
Copy link
Contributor Author

Hi, thanks for your contribution! Before we are able to merge your PR, please don't forget to sign CLA here :)

image

Also, if you get an error message like "xxx seems not to be a GitHub user", it means that the email you used to commit changes does not match the one you used in your GitHub account. You can try to link your local email to your GitHub, or update your local email address and then amend your commits:

git config --global user.email "YOUR_GITHUB_EMAIL"
git commit --amend

I'm done.

@gaotongxiao gaotongxiao merged commit f6da871 into open-mmlab:dev-1.x Dec 16, 2022
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Dec 19, 2022
* [Docs] fix a mistake in user_guides/visualization.md

* [Docs] fix some mistakes in user_guides/dataset_prepare.md

* Update docs/en/user_guides/dataset_prepare.md

Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants