-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add IC13 preparer #1531
Conversation
Codecov ReportBase: 85.81% // Head: 85.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1531 +/- ##
===========================================
+ Coverage 85.81% 85.82% +0.01%
===========================================
Files 158 159 +1
Lines 9881 9927 +46
Branches 1368 1377 +9
===========================================
+ Hits 8479 8520 +41
+ Misses 1159 1158 -1
- Partials 243 249 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dataset_zoo/icdar2013/textrecog.py
Outdated
url='https://download.openmmlab.com/mmocr/data/mixture/icdar_2013/' | ||
'train_label.txt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the image path is unified to textrecog_imgs/${split}
. It might be better if we provide this pre-generated JSON file with the same path. So the IC13 data preparer only needs to download data without conversion.
train/***.png
-> textrecog_imgs/train/***.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
dataset_zoo/icdar2013/textrecog.py
Outdated
url='https://download.openmmlab.com/mmocr/data/mixture/icdar_2013/' | ||
'test_label_1015.txt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Challenge2_Test_Task3_Images/***.png
-> textrecog_imgs/test/***.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
does |
After #1529