Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add IC13 preparer #1531

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

xinke-wang
Copy link
Collaborator

After #1529

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 85.81% // Head: 85.82% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c90424c) compared to base (31c41d8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1531      +/-   ##
===========================================
+ Coverage    85.81%   85.82%   +0.01%     
===========================================
  Files          158      159       +1     
  Lines         9881     9927      +46     
  Branches      1368     1377       +9     
===========================================
+ Hits          8479     8520      +41     
+ Misses        1159     1158       -1     
- Partials       243      249       +6     
Flag Coverage Δ
unittests 85.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../models/textdet/postprocessors/db_postprocessor.py 86.30% <0.00%> (-6.85%) ⬇️
...ocr/datasets/preparers/parsers/icdar_txt_parser.py 82.35% <0.00%> (-5.46%) ⬇️
mmocr/datasets/preparers/parsers/base.py 72.00% <0.00%> (ø)
mmocr/datasets/preparers/data_obtainer.py 20.73% <0.00%> (ø)
mmocr/datasets/preparers/parsers/svt_parser.py 100.00% <0.00%> (ø)
mmocr/utils/bbox_utils.py 61.84% <0.00%> (+1.60%) ⬆️
...r/models/kie/postprocessors/sdmgr_postprocessor.py 91.17% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines 26 to 27
url='https://download.openmmlab.com/mmocr/data/mixture/icdar_2013/'
'train_label.txt',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the image path is unified to textrecog_imgs/${split}. It might be better if we provide this pre-generated JSON file with the same path. So the IC13 data preparer only needs to download data without conversion.

train/***.png -> textrecog_imgs/train/***.png

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 51 to 52
url='https://download.openmmlab.com/mmocr/data/mixture/icdar_2013/'
'test_label_1015.txt',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Challenge2_Test_Task3_Images/***.png -> textrecog_imgs/test/***.png

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Harold-lkk
Copy link
Collaborator

does docs/zh_cn/user_guides/data_prepare/dataset_preparer.md update?

@gaotongxiao gaotongxiao merged commit 5fbb22c into open-mmlab:dev-1.x Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants