Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add CocoTextv2 to dataset preparer #1514

Merged
merged 5 commits into from
Dec 20, 2022

Conversation

xinke-wang
Copy link
Collaborator

Visualized by browse_dataset.py #1503
Screenshot from 2022-11-04 20-43-35

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 85.84% // Head: 85.62% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (b1488c9) compared to base (b1a3b94).
Patch coverage: 9.52% of modified lines in pull request are covered.

❗ Current head b1488c9 differs from pull request most recent head 9c8555b. Consider uploading reports for the commit 9c8555b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1514      +/-   ##
===========================================
- Coverage    85.84%   85.62%   -0.23%     
===========================================
  Files          159      158       -1     
  Lines         9929     9892      -37     
  Branches      1377     1374       -3     
===========================================
- Hits          8524     8470      -54     
- Misses        1159     1176      +17     
  Partials       246      246              
Flag Coverage Δ
unittests 85.62% <9.52%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/datasets/preparers/parsers/coco_parser.py 20.45% <9.52%> (-11.55%) ⬇️
...cr/models/textdet/module_losses/pan_module_loss.py 89.10% <0.00%> (-7.70%) ⬇️
mmocr/utils/bbox_utils.py 60.24% <0.00%> (-1.61%) ⬇️
...r/models/kie/postprocessors/sdmgr_postprocessor.py 91.17% <0.00%> (-1.48%) ⬇️
mmocr/apis/inferencers/mmocr_inferencer.py 16.81% <0.00%> (-0.73%) ⬇️
mmocr/datasets/preparers/parsers/base.py 72.00% <0.00%> (ø)
mmocr/datasets/preparers/data_obtainer.py 20.73% <0.00%> (ø)
mmocr/datasets/preparers/parsers/svt_parser.py
mmocr/datasets/preparers/data_converter.py 21.00% <0.00%> (+0.39%) ⬆️
mmocr/datasets/transforms/textdet_transforms.py 91.79% <0.00%> (+0.52%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add config_generator to the end of each config. Same for other PRs

dataset_zoo/cocotextv2/textrecog.py Show resolved Hide resolved
dataset_zoo/cocotextv2/textspotting.py Show resolved Hide resolved
@gaotongxiao gaotongxiao merged commit 4396e8f into open-mmlab:dev-1.x Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants