-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support modified resnet structure used in oCLIP #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harold-lkk
reviewed
Oct 30, 2022
Harold-lkk
reviewed
Oct 31, 2022
Harold-lkk
reviewed
Nov 1, 2022
Harold-lkk
reviewed
Nov 1, 2022
Harold-lkk
reviewed
Nov 1, 2022
HannibalAPE
force-pushed
the
clip_resnet
branch
2 times, most recently
from
November 1, 2022 17:26
4185727
to
c03a4e5
Compare
HannibalAPE
force-pushed
the
clip_resnet
branch
from
November 1, 2022 17:28
c03a4e5
to
0b6a24d
Compare
Harold-lkk
reviewed
Nov 2, 2022
Harold-lkk
reviewed
Nov 2, 2022
Harold-lkk
reviewed
Nov 2, 2022
gaotongxiao
reviewed
Nov 2, 2022
gaotongxiao
reviewed
Nov 3, 2022
gaotongxiao
approved these changes
Nov 3, 2022
Harold-lkk
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support modified resnet structure used in oCLIP, which is also the official structure in CLIP.
Currently, I only implement CLIPResNet-50 when depth=50. CLIPResNet-101 would be implemented later.
We also provide a script for converting the parameter names of our models to MMOCR style.
For more information, please refer to oCLIP
Modification
Add a new ResNet structure, named as CLIPResNet in mmocr/models/common/backbones/clip_resnet.py
Checklist
Before PR:
After PR: