Skip to content

Conversation

LeoXing1996
Copy link
Collaborator

No description provided.

@LeoXing1996 LeoXing1996 requested a review from plyfager January 23, 2022 08:18
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #233 (18b5c81) into master (c355edb) will increase coverage by 0.30%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   76.71%   77.01%   +0.30%     
==========================================
  Files         130      130              
  Lines        9421     9427       +6     
  Branches     1899     1901       +2     
==========================================
+ Hits         7227     7260      +33     
+ Misses       1728     1703      -25     
+ Partials      466      464       -2     
Flag Coverage Δ
unittests 77.01% <50.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/core/evaluation/metrics.py 79.08% <50.00%> (+3.56%) ⬆️
mmgen/models/architectures/fid_inception.py 94.44% <0.00%> (+2.38%) ⬆️
mmgen/utils/io_utils.py 58.49% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de90c2...18b5c81. Read the comment docs.

@LeoXing1996 LeoXing1996 mentioned this pull request Jan 23, 2022
2 tasks
# Note set your inception_pkl's path
inception_pkl = 'work_dirs/inception_pkl/imagenet.pkl'
inception_pkl = ('https://download.openmmlab.com/mmgen/evaluation/'
'fid_inception_pkl/imagenet.pkl')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may rename to 'imagenet_128x128.pkl'

# Note set your inception_pkl's path
inception_pkl = 'work_dirs/inception_pkl/imagenet.pkl'
inception_pkl = ('https://download.openmmlab.com/mmgen/evaluation/'
'fid_inception_pkl/imagenet.pkl')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as above

@plyfager
Copy link
Collaborator

Later we may complete other inception pkls.

@zengyh1900 zengyh1900 added awaiting response kind/feature request new feature/model/datasets/config etc. priority/P0 highest priority labels Oct 12, 2022
@zengyh1900 zengyh1900 added this to the 0.8.0 milestone Oct 12, 2022
LeoXing1996 pushed a commit to LeoXing1996/mmgeneration that referenced this pull request Oct 27, 2022
* add RDN

* Add docstring and test.

* Tiny fix.

* Tiny fix.

* Add license.

* Tiny Fix

* Tiny Fix

Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature request new feature/model/datasets/config etc. priority/P0 highest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants