Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix psnr,snr,ssim,mae and mse fail to compute on videos #89

Merged
merged 7 commits into from
Feb 13, 2023

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Feb 6, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

psnr,snr,ssim,mae and mse fail to compute on videos.

Modification

  1. psnr,snr,ssim,mae and mse can process inputs with shape [t, h, w, c]
  2. img_transforms/reorder_and_crop can process inputs with shape [t, h, w, c]

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Z-Fran Z-Fran self-assigned this Feb 6, 2023
@Z-Fran Z-Fran removed the request for review from ice-tong February 8, 2023 07:18
mmeval/metrics/mae.py Outdated Show resolved Hide resolved
mmeval/metrics/ssim.py Outdated Show resolved Hide resolved
@zhouzaida
Copy link
Collaborator

Please update unit tests to cover those modificaitons.

@zhouzaida zhouzaida changed the title [Fix] fix psnr,snr,ssim,mae and mse fail to compute on videos [Fix] Fix psnr,snr,ssim,mae and mse fail to compute on videos Feb 13, 2023
@zhouzaida zhouzaida merged commit 5a3647c into open-mmlab:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants