-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeCamp #1535] Add SAD #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-tong
reviewed
Jan 9, 2023
ice-tong
reviewed
Jan 9, 2023
Modify the details. Co-authored-by: yancong <32220263+ice-tong@users.noreply.github.com>
ice-tong
reviewed
Jan 9, 2023
ice-tong
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 comments
Optimize details Co-authored-by: yancong <32220263+ice-tong@users.noreply.github.com>
LeoXing1996
reviewed
Jan 10, 2023
LGTM 🚀 |
Co-authored-by: LeoXing1996 <xingzn1996@hotmail.com>
Please @zhouzaida have a look~ |
ice-tong
reviewed
Jan 11, 2023
zhouzaida
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add MattingSAD of MMEditing to MMEval and complete the adaptation.
Modification
Add MattingSAD of MMEditing to MMEval
The PR link using mmeval.SAD in mmediting:open-mmlab/mmagic#1592 (comment)