-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Publish models after training if published_keys is set in CheckpointHook #987
[Feature] Publish models after training if published_keys is set in CheckpointHook #987
Conversation
To avoid `mypy` warning `mmengine/hooks/checkpoint_hook.py:358: error: Unsupported right operand type for in ("Optional[List[str]]") Found 1 error in 1 file (checked 224 source files)`
Try to avoid trim trailing whitespace waring in hook.md
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Hi, it would be better to also update |
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=======================================
Coverage ? 76.59%
=======================================
Files ? 139
Lines ? 11068
Branches ? 2219
=======================================
Hits ? 8478
Misses ? 2219
Partials ? 371
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Motivation
As #905 described.
Modification
[Enhancement] add automatically Publish in checkpointhook.py and corresponding update document in hook.md
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
For example:
I am training cifar10 using the resnet50 model from the code in the mmengine example docs. And add default_hook in runner
After trainning will publish the model, here is logs:
Here is the resulting folder structure
Use follow code to check and compare the keys
And here is the log:
The full logs: https://github.com/KerwinKai/mmengine/blob/main/20230308_155014.log