-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Support configure enviroment in config. #693
base: main
Are you sure you want to change the base?
Conversation
a00bbfd
to
3e3fecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say that eval
/exec
might make it unsafe. Besides, users might abuse it... Maybe we should consider twice on this?
59ec179
to
a0f6acd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage ? 78.24%
=======================================
Files ? 132
Lines ? 9988
Branches ? 1995
=======================================
Hits ? 7815
Misses ? 1836
Partials ? 337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support config torch enviroment in config by the code block below:
After building the runner,
torch.backends.cuda.matmul.allow_tf32
andtorch.backends.cuda.matmul.allow_fp16_reduced_precision_reduction
are set to TrueModification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist