Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support configure enviroment in config. #693

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support config torch enviroment in config by the code block below:

# Define the config
cfg = ...
cfg.env_cfg.torch_cfg = torch_cfg = dict(
    backends.cuda.matmul.allow_tf32=True,
    torch.backends.cuda.matmul.allow_fp16_reduced_precision_reduction=True
)

After building the runner, torch.backends.cuda.matmul.allow_tf32 and torch.backends.cuda.matmul.allow_fp16_reduced_precision_reduction are set to True

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

mmengine/runner/runner.py Outdated Show resolved Hide resolved
@HAOCHENYE HAOCHENYE added the enhancement New feature or request label Nov 17, 2022
@HAOCHENYE HAOCHENYE added this to the 0.4.0 milestone Nov 17, 2022
@HAOCHENYE HAOCHENYE changed the title [Enhance] Support config torch enviroment in config. [Enhance] Support configure enviroment in config. Nov 21, 2022
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say that eval/exec might make it unsafe. Besides, users might abuse it... Maybe we should consider twice on this?

@HAOCHENYE HAOCHENYE removed this from the 0.4.0 milestone Dec 22, 2022
@HAOCHENYE HAOCHENYE modified the milestones: 0.5.0, 0.6.0 Jan 12, 2023
RangiLyu
RangiLyu previously approved these changes Jan 30, 2023
mmengine/runner/runner.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@2242fca). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #693   +/-   ##
=======================================
  Coverage        ?   78.24%           
=======================================
  Files           ?      132           
  Lines           ?     9988           
  Branches        ?     1995           
=======================================
  Hits            ?     7815           
  Misses          ?     1836           
  Partials        ?      337           
Flag Coverage Δ
unittests 78.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need-design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants