-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] CheckpointHook behavior incorrect if given filename_tmpl
argument
#518
Conversation
filename_tmpl
argumentfilename_tmpl
argument
Codecov ReportBase: 77.68% // Head: 77.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 77.68% 77.85% +0.16%
==========================================
Files 116 116
Lines 8612 8610 -2
Branches 1778 1779 +1
==========================================
+ Hits 6690 6703 +13
+ Misses 1623 1609 -14
+ Partials 299 298 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b54e8a5
to
11b7f7a
Compare
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix
TypeError
when saving checkpoints if isCheckpointHook
is constructed with argumentfilename_tmpl
Modification
filename_tmpl
toCheckpointHook
's keyword argumentBC-breaking (Optional)
No
Use cases (Optional)
Checklist