Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support convert BN to SyncBN by config #506

Merged
merged 8 commits into from
Sep 15, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Sep 1, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

To solve #412

Support converting BN layer of the model to SyncBN layer in the runner.wrap_models:

cfg.convert_sync_bn = 'torch'
runner = Runner(
    ...
    cfg=cfg
)

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne added this to the 0.2.0 milestone Sep 5, 2022
@HAOCHENYE HAOCHENYE mentioned this pull request Sep 5, 2022
mmengine/model/utils.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 77.68% // Head: 77.61% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (1bb9221) compared to base (ca0364b).
Patch coverage: 61.29% of modified lines in pull request are covered.

❗ Current head 1bb9221 differs from pull request most recent head 8bd44a1. Consider uploading reports for the commit 8bd44a1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   77.68%   77.61%   -0.07%     
==========================================
  Files         116      116              
  Lines        8612     8641      +29     
  Branches     1778     1785       +7     
==========================================
+ Hits         6690     6707      +17     
- Misses       1623     1632       +9     
- Partials      299      302       +3     
Flag Coverage Δ
unittests 77.61% <61.29%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmengine/runner/runner.py 84.81% <12.50%> (-0.93%) ⬇️
mmengine/model/utils.py 63.46% <77.27%> (+3.70%) ⬆️
mmengine/model/__init__.py 75.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit 8ee31db into open-mmlab:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants