[Feature] add zorder #1049
Open
[Feature] add zorder #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HAOCHENYE
reviewed
Apr 6, 2023
| @@ -410,7 +417,7 @@ def draw_texts( | |||
| font_families: Union[str, List[str]] = 'sans-serif', | |||
| bboxes: Optional[Union[dict, List[dict]]] = None, | |||
| font_properties: Optional[Union['FontProperties', | |||
| List['FontProperties']]] = None | |||
| List['FontProperties']]] = None, | |||
There was a problem hiding this comment.
suggestion: Union['FontProperties', List['FontProperties'], None] = None,| @@ -615,6 +625,7 @@ def draw_circles( | |||
| line_widths: Union[Union[int, float], List[Union[int, float]]] = 2, | |||
| face_colors: Union[str, tuple, List[str], List[tuple]] = 'none', | |||
| alpha: Union[float, int] = 0.8, | |||
| zorder: float = 1.0, | |||
There was a problem hiding this comment.
What is the reason for using zorder=1.0 for draw_circles but zorder=2.0 for draw_boxes
HAOCHENYE
reviewed
Apr 6, 2023
| @@ -384,6 +385,7 @@ def draw_points(self, | |||
| marker styles. Defaults to None. | |||
| sizes (Optional[Union[np.ndarray, torch.Tensor]]): The marker size. | |||
| Defaults to None. | |||
| zorder (float): The z-order of points. Defaults to 1.0. | |||
There was a problem hiding this comment.
Refer to the description here(https://matplotlib.org/stable/gallery/misc/zorder_demo.html) and refine the docstring
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage ? 76.25%
=======================================
Files ? 139
Lines ? 11074
Branches ? 2218
=======================================
Hits ? 8444
Misses ? 2272
Partials ? 358
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
According to Z-Order of matplotlib, lines will be in the front of circles by defaults, which results in a wrong visualization result in MMPose as follows:
I suggest adding
zorderindraw_xxx()functions to support customized orders.Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist