Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Align the evaluation result in log #1034

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

kitecats
Copy link
Contributor

@kitecats kitecats commented Mar 31, 2023

Fix for issue #981

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

The aligned log is shown in the following figure
1680266104830(1)

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2023

CLA assistant check
All committers have signed the CLA.

@HAOCHENYE
Copy link
Collaborator

Hi, Thanks for your contribution! Could you provide the aligned log message in the PR message after the modification?

@kitecats
Copy link
Contributor Author

kitecats commented Apr 3, 2023

Of course, I have added the aligned log result to the modification information, and I wonder if it meets the requirements?

@zhouzaida zhouzaida changed the title [Feature] Align the evaluation result in log [Enhancement] Align the evaluation result in log Apr 3, 2023
@zhouzaida zhouzaida merged commit 093068e into open-mmlab:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants