Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance]: Update Dockerfile #1946

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Xiangxu-0103 Xiangxu-0103 requested a review from ZCMax November 8, 2022 13:30
@Xiangxu-0103 Xiangxu-0103 requested review from Tai-Wang and removed request for ZCMax November 17, 2022 05:44
@ZwwWayne ZwwWayne force-pushed the dev-1.x branch 2 times, most recently from 72b8e9f to 28fe73d Compare December 3, 2022 08:47
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 46.37% // Head: 46.96% // Increases project coverage by +0.59% 🎉

Coverage data is based on head (c710142) compared to base (d84e081).
Patch coverage: 66.47% of modified lines in pull request are covered.

❗ Current head c710142 differs from pull request most recent head 2c46a12. Consider uploading reports for the commit 2c46a12 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1946      +/-   ##
===========================================
+ Coverage    46.37%   46.96%   +0.59%     
===========================================
  Files          259      262       +3     
  Lines        21390    21964     +574     
  Branches      3379     3460      +81     
===========================================
+ Hits          9919    10315     +396     
- Misses       10827    10987     +160     
- Partials       644      662      +18     
Flag Coverage Δ
unittests 46.96% <66.47%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
mmdet3d/models/detectors/mink_single_stage.py 43.58% <ø> (ø)
mmdet3d/testing/data_utils.py 70.83% <ø> (ø)
mmdet3d/models/voxel_encoders/voxel_encoder.py 38.46% <6.94%> (-12.08%) ⬇️
...t3d/models/data_preprocessors/data_preprocessor.py 39.10% <17.24%> (-5.05%) ⬇️
mmdet3d/datasets/transforms/formating.py 58.03% <33.33%> (+1.78%) ⬆️
mmdet3d/models/data_preprocessors/voxelize.py 33.92% <33.92%> (ø)
mmdet3d/datasets/transforms/loading.py 48.13% <60.60%> (+0.79%) ⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne added this to the 1.1.0rc3 milestone Dec 19, 2022
@JingweiZhang12
Copy link
Contributor

@Xiangxu-0103 Please update this branch

@Xiangxu-0103 Xiangxu-0103 requested a review from ZwwWayne February 3, 2023 04:33
@ZwwWayne
Copy link
Collaborator

Need rebase

@ZwwWayne ZwwWayne merged commit 3e96591 into open-mmlab:dev-1.x Mar 6, 2023
@Xiangxu-0103 Xiangxu-0103 deleted the update_dockerfile branch March 7, 2023 02:07
xizaoqu pushed a commit to xizaoqu/mmdetection3d that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants