Add fix on the bbox loss_weight of the PAA head #6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@gkagkos Thank you very much for your feedback, it seems to be a bug indeed. Can you fix it based on dev 2.19.1? We plan to merge to dev 2.19.1? |
|
Will do shortly. |
|
@hhaAndroid sorry for being late. Changed master tod dev 2.19.1 |
|
Hi @gkagkos , |
|
Done |
ZwwWayne
force-pushed
the
dev-v2.19.1
branch
from
c3ff573 to
54cd1a4
Compare
|
@ZwwWayne can you please close the PR ? |
|
Please sync the code. |
… into paa_loss_fix
hhaAndroid
approved these changes
Dec 24, 2021
ZwwWayne
approved these changes
Dec 24, 2021
ZwwWayne
pushed a commit
that referenced
this pull request
Jul 18, 2022
Co-authored-by: PJLAB\huanghaian <1286304229@qq.com>
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection
that referenced
this pull request
Jul 19, 2022
Co-authored-by: PJLAB\huanghaian <1286304229@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was having a look on the PAA head and I accidentally saw that the loss weight used on the bbox, belongs on the cls. Which I think is wrong.
Modification
I changed this to use the weight of cls.