remove expand loop in bbox head to speed up #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yhcao6
commented
Apr 14, 2019
•
yhcao6
commented
| Model | Mem (GB) | Time (iter/s) |
|---|---|---|
| Mask R50 FPN ori | 4.0 | 0.542 |
| Mask R50 FPN new | 4.0 | 0.468 |
hellock
reviewed
Apr 14, 2019
mmdet/models/bbox_heads/bbox_head.py
Outdated
| @@ -94,10 +94,16 @@ def loss(self, | |||
| cls_score, labels, label_weights, reduce=reduce) | |||
| losses['acc'] = accuracy(cls_score, labels) | |||
| if bbox_pred is not None: | |||
| pos_mask = labels > 0 | |||
There was a problem hiding this comment.
It may be better to rename it as pos_inds.
Merged
JegernOUTT
pushed a commit
to JegernOUTT/mmdetection
that referenced
this pull request
Nov 23, 2019
remove expand loop in bbox head to speed up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.