Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmcv takes
(w, h)
as inputsize
, whilemmdet.core.structures.BitmapMasks
passes in(h, w)
. The mistake did not trigger pytest errors, since all the relevant tests letw == h
.A typical resized mask looks like
![0](https://user-images.githubusercontent.com/39944944/105578345-5f5a8480-5dba-11eb-9116-5f609c2729ba.png)
The bug is fixed and two more test cases are supplied in the pull request.