Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mask resize #4520

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Fix: mask resize #4520

merged 3 commits into from
Jan 27, 2021

Conversation

LutingWang
Copy link
Contributor

mmcv takes (w, h) as input size, while mmdet.core.structures.BitmapMasks passes in (h, w). The mistake did not trigger pytest errors, since all the relevant tests let w == h.

A typical resized mask looks like
0

The bug is fixed and two more test cases are supplied in the pull request.

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #4520 (b6d7aad) into master (3a9f5ef) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4520      +/-   ##
==========================================
- Coverage   62.09%   62.04%   -0.05%     
==========================================
  Files         241      241              
  Lines       18400    18400              
  Branches     3085     3085              
==========================================
- Hits        11426    11417       -9     
- Misses       6416     6426      +10     
+ Partials      558      557       -1     
Flag Coverage Δ
unittests 62.01% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/mask/structures.py 87.87% <ø> (ø)
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 74.45% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9f5ef...b6d7aad. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 56b250f into open-mmlab:master Jan 27, 2021
@LutingWang LutingWang deleted the fix_mask_resize branch January 18, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants