Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paa #4391

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Fix paa #4391

merged 4 commits into from
Jan 12, 2021

Conversation

jshilong
Copy link
Collaborator

@jshilong jshilong commented Jan 4, 2021

resolves #4021, resolves #4372

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #4391 (c97ad21) into master (9cb5543) will decrease coverage by 0.10%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4391      +/-   ##
==========================================
- Coverage   61.94%   61.84%   -0.11%     
==========================================
  Files         239      239              
  Lines       18267    18274       +7     
  Branches     3060     3061       +1     
==========================================
- Hits        11315    11301      -14     
- Misses       6402     6424      +22     
+ Partials      550      549       -1     
Flag Coverage Δ
unittests 61.80% <85.71%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/paa_head.py 89.11% <85.71%> (+0.13%) ⬆️
mmdet/models/roi_heads/mask_scoring_roi_head.py 55.35% <0.00%> (-32.15%) ⬇️
mmdet/models/roi_heads/test_mixins.py 45.03% <0.00%> (-8.40%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 94.62% <0.00%> (-5.38%) ⬇️
mmdet/models/roi_heads/mask_heads/fcn_mask_head.py 70.55% <0.00%> (-1.23%) ⬇️
mmdet/models/dense_heads/corner_head.py 74.45% <0.00%> (-0.41%) ⬇️
mmdet/models/dense_heads/cascade_rpn_head.py 28.07% <0.00%> (-0.20%) ⬇️
mmdet/models/dense_heads/yolact_head.py 87.78% <0.00%> (+3.40%) ⬆️
mmdet/models/detectors/yolact.py 88.88% <0.00%> (+12.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb5543...1f0af57. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 3e3ca6d into open-mmlab:master Jan 12, 2021
@jshilong jshilong deleted the fix_paa branch June 1, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PAA reimplemention question a bug in mmdet/models/dense_heads/paa_head.py
2 participants