Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete work_dir in all configs #2315

Merged
merged 2 commits into from
Mar 24, 2020
Merged

delete work_dir in all configs #2315

merged 2 commits into from
Mar 24, 2020

Conversation

xvjiarui
Copy link
Collaborator

This PR deleted work_dir in all config files.
work_dir will be set the same as file name if not specified.

mmdetection/tools/train.py

Lines 68 to 71 in eeff0be

elif cfg.get('work_dir', None) is None:
# use filename as default work_dir
cfg.work_dir = osp.join('./work_dirs',
osp.splitext(osp.basename(args.config))[0])

@xvjiarui xvjiarui requested a review from hellock March 23, 2020 16:21
@hellock hellock merged commit 465473e into open-mmlab:v2.0 Mar 24, 2020
@xvjiarui xvjiarui deleted the delete_work_dir branch May 7, 2020 12:19
mike112223 pushed a commit to mike112223/mmdetection that referenced this pull request Aug 25, 2020
@xvjiarui
delete work_dir in all configs (open-mmlab#2315)
e8100e8 
* delete work_dir in all configs

* add comment on work_dir priority
FANGAreNotGnu pushed a commit to FANGAreNotGnu/mmdetection that referenced this pull request Oct 23, 2023
@sxjscience
Remove autogluon_contrib_nlp + Remove text tutorials + Revise tutoria…
3268ccb 
…l structure (open-mmlab#2315)

* fix

* Update predictor.py

* remove

* Disable download in transformers package when building tutorials

* Improve the structure of AutoMM tutorial

* Update index.rst

* fix lint

* fix grammar

* fix description

* fix

* reorganize tutorials

* revise document

* Update index.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

@hellock hellock Awaiting requested review from hellock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xvjiarui @ZwwWayne @hellock