-
Notifications
You must be signed in to change notification settings - Fork 9.8k
options for FCNMaskHead during testtime #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellock
reviewed
Jan 27, 2020
| np.array(im_mask[:, :, np.newaxis], order='F'))[0] | ||
| cls_segms[label - 1].append(rle) | ||
|
|
||
| if rcnn_test_cfg.get("box_rel_masks"): |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Single quote is preferred.
- It is better to set the default value to bool type instead of None.
- The two field may be renamed to
crop_mask(False) andrle_mask_encode(True)?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Done
- Done
- Yes!)
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
hellock
approved these changes
Jan 28, 2020
mattdawkins
added a commit
to VIAME/mmdetection
that referenced
this pull request
Mar 13, 2020
* origin/viame/master: (28 commits) Fix FPN upscale Extra compiler args VIAME-specific build parameters Bump version to 1.0.0 (open-mmlab#2029) Fix the incompatibility of the latest numpy and pycocotools (open-mmlab#2024) format configs with yapf (open-mmlab#2023) options for FCNMaskHead during testtime (open-mmlab#2013) Enhance AssignResult and SamplingResult (open-mmlab#1995) Fix typo activatation -> activation (open-mmlab#2007) Reorganize requirements, make albumentations optional (open-mmlab#1969) Encapsulate DCN into a ConvModule & Conv_layers (open-mmlab#1894) Code for Paper "Bridging the Gap Between Anchor-based and Anchor-free… (open-mmlab#1872) Non color images (open-mmlab#1976) Fix albu mask format bug (open-mmlab#1818) Fix CI by limiting the version of torchvision (open-mmlab#2005) Add ability to overwite existing module in Registry (open-mmlab#1982) bug for distributed training (open-mmlab#1985) Update Libra RetinaNet config with the latest code (open-mmlab#1975) Fix issue in refine_bboxes and add doctest (open-mmlab#1962) add link to official repo (open-mmlab#1971) ...
ioir123ju
pushed a commit
to ioir123ju/mmdetection
that referenced
this pull request
Mar 30, 2020
* options for mask during testtime * handle comments
mike112223
pushed a commit
to mike112223/mmdetection
that referenced
this pull request
Aug 25, 2020
* options for mask during testtime * handle comments
FANGAreNotGnu
pushed a commit
to FANGAreNotGnu/mmdetection
that referenced
this pull request
Oct 23, 2023
jben-hun
pushed a commit
to jben-hun/mmdetection
that referenced
this pull request
Jan 10, 2025
* options for mask during testtime * handle comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two more options for test config (see the example bellow).
rle_mask_encode= False you'll recieve N(=number of boxes) binary masks in fullres. In order to decrease memory usage optioncrop_mask=True allows you to get mask with the position inside an appropriate bbox.Both are optional and disabled by default.
Updated and might be referenced as an example of usage.