Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove some unicode chars from en/ docs #10648

Merged

Conversation

evdcush
Copy link
Contributor

@evdcush evdcush commented Jul 15, 2023

Motivation

I am trying to make latexpdf the en/ docs.
Fullwidth chars cause issues for latexpdf build targets, so I replaced them with their normal (half-width) variants.

Modification

  • Added some missing papertype indicators in docs
  • Replaced some unicode fullwidth chars with their halfwidth variants in docs and python code

Use cases

You used to be able to download the docs as pdf until v3.1.0.
I don't know what broke this, but at least some of the work done in this branch should help narrow down probable causes of the pdf build breakage.

Checklist

  1. ✅ Pre-commit or other linting tools are used to fix the potential lint issues.
  2. ✅ The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. ✅ If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. ✅ The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2023

CLA assistant check
All committers have signed the CLA.

@evdcush evdcush marked this pull request as ready for review July 15, 2023 20:50
@evdcush evdcush force-pushed the docs/evdcush/docs-pdf-build-fixes branch from cba5bcb to 6828b55 Compare July 15, 2023 20:54
@evdcush evdcush force-pushed the docs/evdcush/docs-pdf-build-fixes branch from 88ade68 to 358bb40 Compare July 15, 2023 21:05
@hhaAndroid hhaAndroid changed the base branch from main to dev-3.x July 17, 2023 04:29
@evdcush
Copy link
Contributor Author

evdcush commented Jul 20, 2023

How long do PRs typically remain in the pr_stage_test/hold phase?

@evdcush evdcush requested a review from hhaAndroid July 23, 2023 23:14
@hhaAndroid hhaAndroid merged commit ae95e10 into open-mmlab:dev-3.x Jul 24, 2023
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants