Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add box_iou_rotated, ml_nms_rotated and nms_rotated #625

Merged
merged 28 commits into from
Nov 25, 2020
Merged

add box_iou_rotated, ml_nms_rotated and nms_rotated #625

merged 28 commits into from
Nov 25, 2020

Conversation

magicdream2222
Copy link
Contributor

add box_iou_rotated, ml_nms_rotated and nms_rotated ops for pytorch and parrots.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #625 (c68939c) into master (c8146cc) will increase coverage by 0.22%.
The diff coverage is 48.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   64.61%   64.84%   +0.22%     
==========================================
  Files         134      135       +1     
  Lines        7672     7830     +158     
  Branches     1358     1387      +29     
==========================================
+ Hits         4957     5077     +120     
- Misses       2459     2488      +29     
- Partials      256      265       +9     
Flag Coverage Δ
unittests 64.84% <48.73%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/__init__.py 100.00% <ø> (ø)
mmcv/cnn/bricks/conv_module.py 100.00% <ø> (ø)
mmcv/cnn/bricks/depthwise_separable_conv_module.py 100.00% <ø> (ø)
mmcv/image/__init__.py 100.00% <ø> (ø)
mmcv/ops/modulated_deform_conv.py 50.44% <ø> (ø)
mmcv/ops/roi_pool.py 43.90% <ø> (ø)
mmcv/runner/epoch_based_runner.py 79.04% <0.00%> (ø)
mmcv/runner/hooks/logger/tensorboard.py 35.48% <0.00%> (+10.48%) ⬆️
mmcv/runner/hooks/optimizer.py 25.00% <5.26%> (-2.54%) ⬇️
mmcv/ops/roi_align.py 61.33% <9.09%> (-2.73%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8146cc...62d8c34. Read the comment docs.

Copy link
Collaborator

@Johnson-Wang Johnson-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add necessary docstrings to the ops

mmcv/ops/nms.py Outdated Show resolved Hide resolved
tests/data/config/q.py Outdated Show resolved Hide resolved
mmcv/ops/box_iou_rotated.py Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Nov 18, 2020

CLA assistant check
All committers have signed the CLA.

@Johnson-Wang
Copy link
Collaborator

Please kindly sign the CLA.

mmcv/ops/box_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/nms.py Outdated Show resolved Hide resolved
mmcv/ops/nms.py Outdated Show resolved Hide resolved
mmcv/ops/__init__.py Outdated Show resolved Hide resolved
mmcv/ops/nms.py Outdated Show resolved Hide resolved
mmcv/ops/nms.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Johnson-Wang Johnson-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed earlier, multi_label can be safely deleted for the purpose of clearer code structure in cuda files.

mmcv/ops/nms.py Outdated Show resolved Hide resolved
mmcv/ops/nms.py Show resolved Hide resolved
@magicdream2222
Copy link
Contributor Author

ok啦 @Johnson-Wang

@ZwwWayne ZwwWayne merged commit a978764 into open-mmlab:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants