-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace re
with regex
#457
Conversation
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 62.42% 63.20% +0.78%
==========================================
Files 126 127 +1
Lines 7116 7170 +54
Branches 1255 1265 +10
==========================================
+ Hits 4442 4532 +90
+ Misses 2469 2413 -56
- Partials 205 225 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mmcv/cnn/bricks/plugin.py
Outdated
@@ -1,5 +1,6 @@ | |||
import inspect | |||
import re | |||
|
|||
import regex as re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use regex only on windows.
requirements.txt
Outdated
@@ -1,4 +1,5 @@ | |||
addict | |||
numpy | |||
pyyaml | |||
regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regex
is not compulsory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regex;sys_platform=='win32'
This PR takes
regex
to replacere
to solve the issue: "re.error: bad escape \U at position 2", which usually happens in Windows platform.