Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Raise a error if fails to read image #2791

Merged
merged 3 commits into from
May 10, 2023

Conversation

Ezra-Yu
Copy link
Contributor

@Ezra-Yu Ezra-Yu commented May 8, 2023

Motivation

inspired by open-mmlab/mmpretrain#1427

raise error info if imfrombytes fails

run:

LoadImageFromFile()(dict(img_path='https://user-images.githubusercontent.com/9102141/87268895-3e0d0780-c4fe-11ea-849e-6140b7e0d4de.gif')

before modifcation

image

After modifcartion

image

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

Ezra-Yu and others added 3 commits May 10, 2023 18:06
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida changed the title [Enchence] Raise infomation if imfrombytes fails [Enhance] Raise a error if fails to read image May 10, 2023
@zhouzaida zhouzaida merged commit 387b63b into open-mmlab:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants