Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Repalce the implementation of roi_align_rotated with mlu-ops #2657

Merged
merged 1 commit into from
May 31, 2023

Conversation

tudejiang79
Copy link
Contributor

@tudejiang79 tudejiang79 commented Mar 13, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Replace the implementation of roi_align_rotated with mlu-ops.

Modification

  1. Delete mmcv/ops/csrc/common/mlu/roi_align_rotated_mlu_kernel.mlu.
  2. Delete mmcv/ops/csrc/common/mlu/roi_align_rotated_mlu_utils.cpp.
  3. Modify mmcv/ops/csrc/pytorch/mlu/roi_align_rotated_mlu.cpp.
  4. modified: tests/test_ops/test_roi_align_rotated.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida added the MLU label Mar 15, 2023
@zhouzaida zhouzaida changed the base branch from master to 1.x April 20, 2023 11:37
@tudejiang79 tudejiang79 force-pushed the roi_align_rotated_pr branch 4 times, most recently from 3ff1dab to d9d4b0c Compare April 21, 2023 03:00
@tudejiang79 tudejiang79 reopened this May 19, 2023
@zhouzaida zhouzaida changed the title [Feature] Repalce the implementation of roi_align_rotated with mlu-ops [Refactor] Repalce the implementation of roi_align_rotated with mlu-ops May 31, 2023
@zhouzaida zhouzaida merged commit 58e7c8c into open-mmlab:1.x May 31, 2023
Danielmic pushed a commit to Danielmic/mmcv that referenced this pull request Jun 30, 2023
fwenguang pushed a commit to fwenguang/mmcv that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants