Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add the support of voxelization op for ascend device #2613

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[Feature] Add the support of voxelization op for ascend device #2613

merged 2 commits into from
Mar 3, 2023

Conversation

dflhw
Copy link
Contributor

@dflhw dflhw commented Feb 21, 2023

This PR is for adaptation of the op which name is "voxelization" on ascend npu device. You can use the op on npu-device by this PR.

@ckirchhoff2021 ckirchhoff2021 self-requested a review March 1, 2023 02:59
@ckirchhoff2021 ckirchhoff2021 changed the title [Feature] Add voxelization npu adapter [Feature] Add the support of op "voxelization" for ascend device Mar 1, 2023
ckirchhoff2021
ckirchhoff2021 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@zhouzaida zhouzaida requested a review from grimoire March 3, 2023 03:19
grimoire
grimoire approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida added the NPU Ascend label Mar 3, 2023
@zhouzaida zhouzaida changed the title [Feature] Add the support of op "voxelization" for ascend device [Feature] Add the support of voxelization op for ascend device Mar 3, 2023
@zhouzaida zhouzaida merged commit 7459859 into open-mmlab:master Mar 3, 2023
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
@dflhw @CokeDong
[Feature] Add the support of voxelization op for ascend device (open-…
ead6aa6 
…mmlab#2613)

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@ckirchhoff2021 ckirchhoff2021 ckirchhoff2021 approved these changes

@grimoire grimoire grimoire approved these changes

Assignees

@ice-tong ice-tong

Labels
NPU Ascend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dflhw @grimoire @ckirchhoff2021 @zhouzaida @ice-tong