Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows workflow #2503

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Fix windows workflow #2503

merged 1 commit into from
Dec 20, 2022

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

https://stackoverflow.com/questions/74366357/updating-to-visual-studio-17-4-0-yields-linker-errors-related-to-tls

Modification

Downgrade windows image version.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 66.70% // Head: 66.70% // No change to project coverage 👍

Coverage data is based on head (7348e2a) compared to base (d510b8b).
Patch has no changes to coverable lines.

❗ Current head 7348e2a differs from pull request most recent head a0abf50. Consider uploading reports for the commit a0abf50 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #2503   +/-   ##
=======================================
  Coverage   66.70%   66.70%           
=======================================
  Files         120      120           
  Lines        7817     7817           
  Branches     1072     1072           
=======================================
  Hits         5214     5214           
  Misses       2436     2436           
  Partials      167      167           
Flag Coverage Δ
unittests 66.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit 32cc2f7 into open-mmlab:2.x Dec 20, 2022
tyomj pushed a commit to tyomj/mmcv that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants