[Enhancement] Support value_proj_ratio in MultiScaleDeformableAttention #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2022
Codecov ReportBase: 66.62% // Head: 66.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2452 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 120 120
Lines 7799 7800 +1
Branches 1067 1067
=======================================
+ Hits 5196 5197 +1
Misses 2436 2436
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zhouzaida
reviewed
Nov 24, 2022
zhouzaida
reviewed
Nov 24, 2022
zhouzaida
reviewed
Nov 24, 2022
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
zhouzaida
reviewed
Nov 25, 2022
zhouzaida
reviewed
Nov 25, 2022
zhouzaida
reviewed
Nov 25, 2022
zhouzaida
approved these changes
Dec 11, 2022
tyomj
pushed a commit
to tyomj/mmcv
that referenced
this pull request
May 8, 2023
…on (open-mmlab#2452) * add ratio in ms_deform_attn_ * add ratio in ms_deform_attn * Update mmcv/ops/multi_scale_deform_attn.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> * Update tests/test_ops/test_ms_deformable_attn.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> * add ratio in ms_deform_attn * add ratio in ms_deform_attn * add ratio in ms_deform_attn * add ratio in ms_deform_attn * add ratio in ms_deform_attn * add ratio in ms_deform_attn Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modified for use with ViT-Adapter.
https://github.com/czczup/ViT-Adapter/blob/main/detection/ops/modules/ms_deform_attn.py#L29
Related PR
open-mmlab/mmpretrain#1209
open-mmlab/mmdetection#9354
Checklist
Before PR:
After PR: