Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support modulated_deform_conv with cambricon MLU backend #2411

Merged
merged 5 commits into from
Dec 4, 2022

Conversation

mengpenghui
Copy link

@mengpenghui mengpenghui commented Nov 14, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation of the PR is to support running modulated_deform_conv with Cambricon MLU backend.

It includes two parts:

1. Refactor modulated_deform_conv.py to support MLU backend.
2. Refactor test_modulated_deform_conv.py to support testing modulated_deform_conv with MLU backend.

Modification

  • PyTorch adaptation
    Adapt modulated_deform_conv for PyTorch in :
    mmcv/ops/modulated_deform_conv.py
    mmcv/ops/__init__.py

  • Unit test
    Support test modulated_deform_conv with various backends in :
    tests/test_ops/test_modulated_deform_conv.py

  • Documentation
    Added modulated_deform_conv to operator support document of mlu in :
    docs/en/understand_mmcv/ops.md
    docs/zh_cn/understand_mmcv/ops.md

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2022

CLA assistant check
All committers have signed the CLA.

@mengpenghui mengpenghui marked this pull request as draft November 14, 2022 08:58
@mengpenghui mengpenghui force-pushed the mph_DCNv2_MLU branch 6 times, most recently from 3f72469 to 7cb0cd7 Compare November 15, 2022 08:01
@zhouzaida zhouzaida added the MLU label Nov 16, 2022
@zhouzaida zhouzaida marked this pull request as ready for review December 2, 2022 07:18
@mengpenghui mengpenghui force-pushed the mph_DCNv2_MLU branch 5 times, most recently from 5e5d1c7 to a7bb388 Compare December 2, 2022 10:05
@zhouzaida zhouzaida merged commit 49d8917 into open-mmlab:master Dec 4, 2022
ckirchhoff2021 pushed a commit to ckirchhoff2021/mmcv that referenced this pull request Dec 21, 2022
…pen-mmlab#2411)

* [Feature] Support modulated_deform_conv with cambricon MLU backend

* fix error of torch_mlu

* modify with commit suggestion

* Update modulated_deform_conv.py

* Update mmcv/ops/modulated_deform_conv.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@OpenMMLab-Assistant001
Copy link

Hi @mengpenghui ~

First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants