-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support MultiScaleDeformableAttn with cambricon MLU backend #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZShaopeng
changed the title
[Feature] Support MsDeformAttnForward with cambricon MLU backend
[Feature] Support MsDeformAttn with cambricon MLU backend
Nov 8, 2022
zhouzaida
reviewed
Nov 8, 2022
zhouzaida
reviewed
Nov 8, 2022
zhouzaida
reviewed
Nov 8, 2022
zhouzaida
reviewed
Nov 8, 2022
zhouzaida
reviewed
Nov 8, 2022
Unit test |
zhouzaida
changed the title
[Feature] Support MsDeformAttn with cambricon MLU backend
[WIP] Support MsDeformAttn with cambricon MLU backend
Nov 11, 2022
This reverts commit 27963cc.
zhouzaida
changed the title
[WIP] Support MsDeformAttn with cambricon MLU backend
[Feature] Support MsDeformAttn with cambricon MLU backend
Nov 15, 2022
grimoire
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhouzaida
approved these changes
Nov 16, 2022
zhouzaida
changed the title
[Feature] Support MsDeformAttn with cambricon MLU backend
[Feature] Support MultiScaleDeformableAttn with cambricon MLU backend
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The motivation of the PR is to support running MultiScaleDeformAttn with Cambricon MLU backend.
It includes five parts:
Modification
Add MLU src code of MultiScaleDeformAttn in directory:
mmcv/ops/csrc/common/mlu/ms_deform_attn_mlu_kernel.mlu,
mmcv/ops/csrc/common/mlu/common_mlu_helper.hpp.
Adapt MultiScaleDeformAttn for PyTorch in directory:
mmcv/ops/csrc/pytorch/mlu/ms_deform_attn_mlu.cpp,
mmcv/ops/multi_scale_deform_attn.py.
Support test MultiScaleDeformAttn with various backends in test_ms_deformable_attn.py.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: