Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Refine installation steps #1977

Merged
merged 25 commits into from
Oct 17, 2022
Merged

[Docs] Refine installation steps #1977

merged 25 commits into from
Oct 17, 2022

Conversation

zhouzaida
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Simplify the steps to install mmcv-full.

Modification

  • Update README_zh-CN.md

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida added the WIP label May 23, 2022
HAOCHENYE
HAOCHENYE reviewed Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-mmlab/mmcv/blame/8c1cca1be2b8ea4dfc4f4b4293a0e0994fe5c6d0/README_zh-CN.md#L168

image

Unnecessary blank.

HAOCHENYE
HAOCHENYE reviewed Jul 6, 2022
View reviewed changes
README_zh-CN.md Outdated Show resolved Hide resolved
@zhouzaida zhouzaida requested a review from hellock July 7, 2022 14:57
@zhouzaida zhouzaida force-pushed the refactor-installation-steps branch from 6f625a9 to 865261d Compare July 24, 2022 16:16
@zhouzaida zhouzaida changed the title [Docs] Refine README [Docs] Refine installation steps Jul 25, 2022
@zhouzaida zhouzaida added this to the 1.6.3 milestone Oct 16, 2022
C1rN09
C1rN09 reviewed Oct 17, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
C1rN09
C1rN09 reviewed Oct 17, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
C1rN09
C1rN09 reviewed Oct 17, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
HAOCHENYE
HAOCHENYE reviewed Oct 17, 2022
View reviewed changes
README.md Show resolved Hide resolved
HAOCHENYE
HAOCHENYE reviewed Oct 17, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
HAOCHENYE
HAOCHENYE reviewed Oct 17, 2022
View reviewed changes
README_zh-CN.md Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit bd1da5a into open-mmlab:master Oct 17, 2022
@zhouzaida zhouzaida deleted the refactor-installation-steps branch October 17, 2022 09:10
cathyzhang222 pushed a commit to cathyzhang222/mmcv that referenced this pull request Oct 20, 2022
@zhouzaida @cathyzhang222
[Docs] Refine README and installation documentations (open-mmlab#1977)
b340760 
* [Docs] Refine README

* refine table

* minor refinement

* refine

* refine

* add version info

* add version info

* update version info

* refine

* refine

* add module links in docs/en/introduction

* update docs/en

* fix typo

* update docs/en

* add version.json in zh_cn

* minor refinement

* update version.json

* update Dockerfile

* minor fix

* update installation of macOS

* resolve comments
cathyzhang222 pushed a commit to cathyzhang222/mmcv that referenced this pull request Oct 20, 2022
@zhouzaida @cathyzhang222
[Docs] Refine README and installation documentations (open-mmlab#1977)
1f92f51 
* [Docs] Refine README

* refine table

* minor refinement

* refine

* refine

* add version info

* add version info

* update version info

* refine

* refine

* add module links in docs/en/introduction

* update docs/en

* fix typo

* update docs/en

* add version.json in zh_cn

* minor refinement

* update version.json

* update Dockerfile

* minor fix

* update installation of macOS

* resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C1rN09 C1rN09 C1rN09 approved these changes

@HAOCHENYE HAOCHENYE HAOCHENYE approved these changes

@ZwwWayne ZwwWayne Awaiting requested review from ZwwWayne

@hellock hellock Awaiting requested review from hellock

Assignees

@teamwong111 teamwong111

Labels
None yet
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@zhouzaida @HAOCHENYE @C1rN09 @teamwong111