-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add fps op from mmdet3d #1337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1337 +/- ##
==========================================
- Coverage 68.57% 68.25% -0.33%
==========================================
Files 164 166 +2
Lines 10897 11000 +103
Branches 1993 1997 +4
==========================================
+ Hits 7473 7508 +35
- Misses 3032 3102 +70
+ Partials 392 390 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Suggest migrating all DIVUP to GET_BLOCKS as they essentially do the same thing but GET_BLOCKS looks safer. |
Motivation
Add furthest point sample cuda operation from mmdet3d (branch: v1.0.0.dev0).
Modification
Several files in mmcv/ops folder.
BC-breaking (Optional)
No.
Use cases (Optional)
from mmcv.ops import furthest_point_sample, furthest_point_sample_with_dist