Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add fps op from mmdet3d #1337

Merged
merged 13 commits into from
Oct 13, 2021
Merged

Conversation

DCNSW
Copy link
Contributor

@DCNSW DCNSW commented Sep 15, 2021

Motivation

Add furthest point sample cuda operation from mmdet3d (branch: v1.0.0.dev0).

Modification

Several files in mmcv/ops folder.

BC-breaking (Optional)

No.

Use cases (Optional)

from mmcv.ops import furthest_point_sample, furthest_point_sample_with_dist

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1337 (a6a7156) into master (a90b397) will decrease coverage by 0.32%.
The diff coverage is 33.63%.

❗ Current head a6a7156 differs from pull request most recent head 806f086. Consider uploading reports for the commit 806f086 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
- Coverage   68.57%   68.25%   -0.33%     
==========================================
  Files         164      166       +2     
  Lines       10897    11000     +103     
  Branches     1993     1997       +4     
==========================================
+ Hits         7473     7508      +35     
- Misses       3032     3102      +70     
+ Partials      392      390       -2     
Flag Coverage Δ
unittests 68.25% <33.63%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/dist_utils.py 51.06% <0.00%> (+1.06%) ⬆️
mmcv/ops/points_sampler.py 25.33% <25.33%> (ø)
mmcv/ops/furthest_point_sample.py 50.00% <50.00%> (ø)
mmcv/ops/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90b397...806f086. Read the comment docs.

@zhouzaida zhouzaida mentioned this pull request Sep 15, 2021
16 tasks
@zhouzaida zhouzaida added the CUDA label Sep 21, 2021
@zhouzaida zhouzaida mentioned this pull request Sep 24, 2021
29 tasks
mmcv/ops/points_sampler.py Outdated Show resolved Hide resolved
mmcv/ops/points_sampler.py Outdated Show resolved Hide resolved
mmcv/ops/points_sampler.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne
Copy link
Collaborator

Suggest migrating all DIVUP to GET_BLOCKS as they essentially do the same thing but GET_BLOCKS looks safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants