Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support MAE metric #871

Merged
merged 2 commits into from
May 8, 2022
Merged

[Feature] Support MAE metric #871

merged 2 commits into from
May 8, 2022

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #871 (d310a8c) into master (1f1e9bc) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   83.12%   83.18%   +0.06%     
==========================================
  Files         220      221       +1     
  Lines       12453    12508      +55     
  Branches     2017     2031      +14     
==========================================
+ Hits        10351    10405      +54     
- Misses       1785     1786       +1     
  Partials      317      317              
Flag Coverage Δ
unittests 83.14% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/core/__init__.py 100.00% <100.00%> (ø)
mmedit/core/evaluation/__init__.py 100.00% <100.00%> (ø)
mmedit/core/evaluation/metrics.py 97.07% <100.00%> (+0.28%) ⬆️
...edit/models/backbones/vfi_backbones/tof_vfi_net.py 94.18% <0.00%> (-4.66%) ⬇️
mmedit/core/evaluation/eval_hooks.py 61.53% <0.00%> (-0.63%) ⬇️
mmedit/datasets/__init__.py 100.00% <0.00%> (ø)
mmedit/datasets/vfi_vimeo90k_7frames_dataset.py 100.00% <0.00%> (ø)
mmedit/datasets/pipelines/augmentation.py 98.89% <0.00%> (+0.39%) ⬆️
mmedit/datasets/pipelines/formating.py 99.05% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1e9bc...d310a8c. Read the comment docs.

img1, img2 = img1 / 255., img2 / 255.
if isinstance(convert_to, str) and convert_to.lower() == 'y':
img1 = mmcv.bgr2ycbcr(img1, y_only=True)
img2 = mmcv.bgr2ycbcr(img2, y_only=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this function assume bgr input? Should it accept rgb too?

I suggest convert_to be some string like 'bgr2y' or 'rgb2y', and the mmcv.bgr2ycbcr is retrieved from a str to function dict.

func = convert_dict['rgb2y']
img1 = func(img1, y_only=True)

@wangruohui wangruohui merged commit 286dbeb into open-mmlab:master May 8, 2022
wangruohui pushed a commit to wangruohui/mmediting that referenced this pull request Jul 7, 2022
* [Feature] Support MAE metric

* Update
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Feature] Support MAE metric

* Update
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Feature] Support MAE metric

* Update
biubiubiiu added a commit to biubiubiiu/derain-toolbox that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants