-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support MAE metric #871
Conversation
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
==========================================
+ Coverage 83.12% 83.18% +0.06%
==========================================
Files 220 221 +1
Lines 12453 12508 +55
Branches 2017 2031 +14
==========================================
+ Hits 10351 10405 +54
- Misses 1785 1786 +1
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
img1, img2 = img1 / 255., img2 / 255. | ||
if isinstance(convert_to, str) and convert_to.lower() == 'y': | ||
img1 = mmcv.bgr2ycbcr(img1, y_only=True) | ||
img2 = mmcv.bgr2ycbcr(img2, y_only=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this function assume bgr input? Should it accept rgb too?
I suggest convert_to
be some string like 'bgr2y'
or 'rgb2y'
, and the mmcv.bgr2ycbcr
is retrieved from a str
to function
dict.
func = convert_dict['rgb2y']
img1 = func(img1, y_only=True)
* [Feature] Support MAE metric * Update
* [Feature] Support MAE metric * Update
* [Feature] Support MAE metric * Update
cherry pick from open-mmlab/mmagic#871
No description provided.