[Fix] Modify double lq_path to gt_path in test_pipeline
#862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sequences may start from a frame index other than 0.
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
=======================================
Coverage 83.12% 83.12%
=======================================
Files 220 220
Lines 12453 12453
Branches 2017 2017
=======================================
Hits 10351 10351
Misses 1785 1785
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
I think this is not a typo. In test pipeline, we don't actually have the |
This is a typo.
Besides, the reason why this typo doesn't raise any error is that |
wangruohui
changed the title
lq_path to lq_path and gt_path in
wangruohui
changed the title
lq_path to lq_path and gt_path in lq_path to lq_path and gt_path in test_pipeline
wangruohui
changed the title
lq_path to lq_path and gt_path in test_pipelinelq_path to gt_path in test_pipeline
Yshuo-Li
approved these changes
Apr 28, 2022
Yshuo-Li
pushed a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
…mlab#862) * polish * Use all frames in a sequence dir Some sequences may start from a frame index other than 0. * Polish * remove , to fix lint * Add docstring for `start_idx` * Fix typos Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
Yshuo-Li
pushed a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
…mlab#862) * polish * Use all frames in a sequence dir Some sequences may start from a frame index other than 0. * Polish * remove , to fix lint * Add docstring for `start_idx` * Fix typos Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
meta_keysin config files might should be['lq_path', 'gt_path']instead of['lq_path', 'lq_path'].PS Two ipynb files 1 and 2 should be re-run to fix the typos. I haven't done that yet.