-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support ReduceLrUpdaterHook #860
Conversation
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 83.26% 83.48% +0.22%
==========================================
Files 222 222
Lines 12669 12808 +139
Branches 2054 2093 +39
==========================================
+ Hits 10549 10693 +144
+ Misses 1795 1784 -11
- Partials 325 331 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lr_updater = LinearLrUpdaterHook(by_epoch=True) | ||
lr_updater.get_lr(fake_runner, 1) | ||
lr_updater.start = 10 | ||
lr_updater.get_lr(fake_runner, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to at least assert something in the test, e.g. if the learning rate reduces to a desired value.
Same for test_reduce_lr_updater_hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this another feature irrelevant to reducing on the plateau?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this another feature irrelevant to reducing on the plateau?
Yes, it is another feature irrelevant to reducing on the plateau, which is in lack of unit test
We still need to assert the |
* [Feature] Support ReduceLrUpdaterHook * Update * Update unittest
* [Feature] Support ReduceLrUpdaterHook * Update * Update unittest
* [Feature] Support ReduceLrUpdaterHook * Update * Update unittest
* [Feature] Support ReduceLrUpdaterHook * Update * Update unittest
No description provided.