Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support non-zero frame index for SRFolderVideoDataset & Fix Typos #853

Merged
merged 5 commits into from
Apr 23, 2022
Merged

Conversation

ryanxingql
Copy link
Contributor

@ryanxingql ryanxingql commented Apr 20, 2022

Polish

  1. Correct "annoations" to "annotations".
  2. Correct "propgation" to "propagation".
  3. Remove undefined functions in mmedit/datasets/pipelines/__init__.py.

Improvement

Some sequences may start from a frame index other than 0.
If without annotation files, SRFolderVideoDataset cannot process these sequences correctly; sequences must start from 0.
But in many cases, we use our own data-sets to train video SR methods such as EDVR, and the sequences in these data-sets may start from a frame index other than 0.

Some sequences may start from a frame index other than 0.
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #853 (9e8fb9a) into master (a023cdf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   83.10%   83.12%   +0.01%     
==========================================
  Files         220      220              
  Lines       12452    12453       +1     
  Branches     2017     2017              
==========================================
+ Hits        10348    10351       +3     
+ Misses       1786     1785       -1     
+ Partials      318      317       -1     
Flag Coverage Δ
unittests 83.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/comp1k_dataset.py 100.00% <ø> (ø)
mmedit/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmedit/datasets/sr_annotation_dataset.py 100.00% <ø> (ø)
mmedit/datasets/sr_facial_landmark_dataset.py 100.00% <ø> (ø)
mmedit/datasets/sr_folder_dataset.py 100.00% <ø> (ø)
mmedit/datasets/sr_folder_gt_dataset.py 100.00% <ø> (ø)
mmedit/datasets/sr_folder_multiple_gt_dataset.py 100.00% <ø> (ø)
mmedit/datasets/sr_folder_ref_dataset.py 89.18% <ø> (ø)
mmedit/datasets/sr_lmdb_dataset.py 100.00% <ø> (ø)
mmedit/datasets/sr_reds_dataset.py 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a023cdf...9e8fb9a. Read the comment docs.

@wangruohui wangruohui requested a review from ckkelvinchan April 21, 2022 08:13
@wangruohui
Copy link
Member

wangruohui commented Apr 21, 2022

Hi,

It seems the linter fails. Would you please format the file you modified using yapf?
You can use that in vscode or pycharm.

Another option is to configure pre-commit hook following this

@ryanxingql
Copy link
Contributor Author

ryanxingql commented Apr 21, 2022

Hi @wangruohui , thanks for your response!

I have tried to polish my file through yapf, but nothing changed. Can you give me some suggestions?

Thank you!

PS the problematic commit id is: 88ea442
I have tried to polish the modified file mmedit/datasets/sr_folder_video_dataset.py.

@ryanxingql
Copy link
Contributor Author

@wangruohui Thank you so much!

@wangruohui
Copy link
Member

Hello @ryanxingql ,

Still one more thing to de before merging. As you have modified the argument list, you need to add a docstring to indicate its usage for future users. Just add a description around line 54-55.

Thank you!

@ryanxingql
Copy link
Contributor Author

Hello @ryanxingql ,

Still one more thing to de before merging. As you have modified the argument list, you need to add a docstring to indicate its usage for future users. Just add a description around line 54-55.

Thank you!

No problem! I have added the docstring. Please check.

@wangruohui wangruohui changed the title Polish & Improvement [Enhance] Support non-zero frame index for SRFolderVideoDataset & Fix Typos Apr 22, 2022
@wangruohui wangruohui merged commit a852622 into open-mmlab:master Apr 23, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants