-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Support non-zero frame index for SRFolderVideoDataset
& Fix Typos
#853
Conversation
Some sequences may start from a frame index other than 0.
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
==========================================
+ Coverage 83.10% 83.12% +0.01%
==========================================
Files 220 220
Lines 12452 12453 +1
Branches 2017 2017
==========================================
+ Hits 10348 10351 +3
+ Misses 1786 1785 -1
+ Partials 318 317 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi, It seems the linter fails. Would you please format the file you modified using yapf? Another option is to configure pre-commit hook following this |
Hi @wangruohui , thanks for your response! I have tried to polish my file through yapf, but nothing changed. Can you give me some suggestions? Thank you! PS the problematic commit id is: 88ea442 |
@wangruohui Thank you so much! |
Hello @ryanxingql , Still one more thing to de before merging. As you have modified the argument list, you need to add a docstring to indicate its usage for future users. Just add a description around line 54-55. Thank you! |
No problem! I have added the docstring. Please check. |
SRFolderVideoDataset
& Fix Typos
Polish
mmedit/datasets/pipelines/__init__.py
.Improvement
Some sequences may start from a frame index other than 0.
If without annotation files,
SRFolderVideoDataset
cannot process these sequences correctly; sequences must start from 0.But in many cases, we use our own data-sets to train video SR methods such as EDVR, and the sequences in these data-sets may start from a frame index other than 0.