Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use --diff-seed to set different torch seed on different rank #781

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@mm-assistant mm-assistant bot added the size/XS label Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #781 (796c0e1) into master (4e0f286) will increase coverage by 0.03%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   83.04%   83.08%   +0.03%     
==========================================
  Files         216      216              
  Lines       12239    12253      +14     
  Branches     1975     1978       +3     
==========================================
+ Hits        10164    10180      +16     
+ Misses       1767     1764       -3     
- Partials      308      309       +1     
Flag Coverage Δ
unittests 83.04% <58.82%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/builder.py 93.22% <0.00%> (-1.61%) ⬇️
mmedit/apis/train.py 30.08% <57.14%> (+12.08%) ⬆️
mmedit/apis/__init__.py 100.00% <100.00%> (ø)
...t/models/video_interpolators/basic_interpolator.py 97.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44567aa...796c0e1. Read the comment docs.

@Yshuo-Li Yshuo-Li requested a review from wangruohui March 10, 2022 12:05
@wangruohui wangruohui changed the title [Feature]: Add diff seeds to diff ranks and set torch seed in worker_init_fn [Feature] Add diff_seeds to diff ranks and set torch seed in worker_init_fn Mar 23, 2022
@wangruohui wangruohui changed the title [Feature] Add diff_seeds to diff ranks and set torch seed in worker_init_fn [Feature] Support using different torch seed on different rank Mar 23, 2022
@wangruohui wangruohui changed the title [Feature] Support using different torch seed on different rank [Feature] Use --diff-seed to set different torch seed on different rank Mar 23, 2022
@wangruohui wangruohui merged commit 4ff208e into open-mmlab:master Mar 23, 2022
@Yshuo-Li Yshuo-Li deleted the seed branch April 7, 2022 07:41
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
…rank (open-mmlab#781)

* [Feature]: Add diff seeds to diff ranks and set torch seed in worker_init_fn

* [Feature]: Add diff seeds to diff ranks and set torch seed in worker_init_fn

* Update train.py
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
…rank (open-mmlab#781)

* [Feature]: Add diff seeds to diff ranks and set torch seed in worker_init_fn

* [Feature]: Add diff seeds to diff ranks and set torch seed in worker_init_fn

* Update train.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants