Do not load pretrained VGG #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 80.54% 80.35% -0.20%
==========================================
Files 190 190
Lines 10338 10260 -78
Branches 1533 1533
==========================================
- Hits 8327 8244 -83
- Misses 1781 1783 +2
- Partials 230 233 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
Aug 6, 2021
mmedit/models/extractors/lte.py
Outdated
| @@ -30,7 +30,7 @@ def __init__(self, requires_grad=True, pixel_range=1., pretrained=None): | |||
| pixel_range=pixel_range, img_mean=vgg_mean, img_std=vgg_std) | |||
|
|
|||
| # use vgg19 weights to initialize | |||
| vgg_pretrained_features = models.vgg19(pretrained=True).features | |||
| vgg_pretrained_features = models.vgg19(pretrained=False).features | |||
There was a problem hiding this comment.
What's the motivation of this change?
There was a problem hiding this comment.
Avoid downloading VGG in unittest of CI.
innerlee
approved these changes
Aug 6, 2021
Yshuo-Li
added a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
* Don not load pretrained VGG * Add load_pretrained_vgg Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.