Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix restoration_video_demo bug #1262

Merged
merged 2 commits into from
Oct 12, 2022
Merged

[Fix] fix restoration_video_demo bug #1262

merged 2 commits into from
Oct 12, 2022

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Oct 11, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix restoration_video_demo bug of some input directory cases.

Modification

mmedit/apis/restoration_video_inference.py

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran added the kind/bug something isn't working label Oct 11, 2022
@Z-Fran Z-Fran added this to the 0.16.0 milestone Oct 11, 2022
@Z-Fran Z-Fran requested a review from zengyh1900 October 11, 2022 09:16
@Z-Fran Z-Fran self-assigned this Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 83.86% // Head: 83.87% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a2a2cfc) compared to base (bef5816).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head a2a2cfc differs from pull request most recent head e937b60. Consider uploading reports for the commit e937b60 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   83.86%   83.87%           
=======================================
  Files         223      223           
  Lines       12739    12736    -3     
  Branches     1990     1990           
=======================================
- Hits        10684    10682    -2     
+ Misses       1716     1715    -1     
  Partials      339      339           
Flag Coverage Δ
unittests 83.87% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/apis/restoration_video_inference.py 16.36% <0.00%> (-2.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications look good to me. Please merge it after it passes all the checks.

@zengyh1900 zengyh1900 merged commit 27f14e4 into master Oct 12, 2022
@zengyh1900 zengyh1900 deleted the fix-vsrdemo branch October 12, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug something isn't working priority/P0 highest priority status/WIP work in progress normally
Projects
None yet
2 participants