Skip to content

[Fix] the path separator problem of mim run on Windows #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

RangeKing
Copy link
Contributor

Motivation

mim run mmdet analyze_logs plot_curve .\yolov5_n-v61_syncbn_fast_8xb16-300e_coco_20220919_090739.l og.json --keys loss_cls --legend loss_cls

before:
image

after:
image

Modification

replace all '/' with os.sep in run.py

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 56.62% // Head: 56.62% // No change to project coverage 👍

Coverage data is based on head (1624b27) compared to base (6d94741).
Patch coverage: 20.00% of modified lines in pull request are covered.

❗ Current head 1624b27 differs from pull request most recent head 855ef04. Consider uploading reports for the commit 855ef04 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   56.62%   56.62%           
=======================================
  Files          24       24           
  Lines        1584     1584           
  Branches      334      334           
=======================================
  Hits          897      897           
  Misses        549      549           
  Partials      138      138           
Flag Coverage Δ
unittests 56.62% <20.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mim/commands/run.py 49.31% <20.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida requested a review from ice-tong December 12, 2022 06:36
@ice-tong
Copy link
Collaborator

Hi @RangeKing, sorry for the late reply. This changes looks grate to me, thanks for your contribution!

@zhouzaida zhouzaida merged commit fae573e into open-mmlab:main Dec 20, 2022
@RangeKing RangeKing deleted the win_sep branch February 21, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants