Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Whisper and WeNet Contents Extractor #32

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

Adorable-Qin
Copy link
Collaborator

@Adorable-Qin Adorable-Qin commented Dec 14, 2023

  • Deleted modules/whisper_extractor. Change to OpenAI's Whisper API for content features' extraction.
  • Deleted redundant files in modules/wenet_extractor.

@Adorable-Qin Adorable-Qin changed the title Use Whisper API of OpenAI and deleted redundant files Use Whisper API of OpenAI and delete redundant files Dec 14, 2023
@lmxue lmxue requested a review from RMSnow December 14, 2023 13:51
Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any more pip dependencies?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss for whisper extractor. Line154 is modified by me, which is different from the original whisper code. The purpose is to avoid from downloading whisper's pretrained model automatically from the OpenAI's server, since some running servers of users (like me) are out of network.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put your checkpoints in the right place, i.e. model path specified in your config, I don't think it should be a problem though.

@Adorable-Qin
Copy link
Collaborator Author

Are there any more pip dependencies?

No. Since openai-whisper has already been added to env.sh, we don't need to borrow it to the repo as code format, nor do we need to add the other pip dependency.

@Adorable-Qin
Copy link
Collaborator Author

Modified the download_root of whisper model. If the given path is a file, its dir will be used as the download root. On the other hand, it will be used directly if it is a folder.

Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use black to format this file.

@RMSnow RMSnow changed the title Use Whisper API of OpenAI and delete redundant files Refine Whisper and WeNet Contents Extractor Dec 15, 2023
@RMSnow RMSnow merged commit 3adde48 into open-mmlab:main Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants