Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaskGCT #283

Merged
merged 7 commits into from
Oct 20, 2024
Merged

Add MaskGCT #283

merged 7 commits into from
Oct 20, 2024

Conversation

HeCheng0625
Copy link
Collaborator

@HeCheng0625 HeCheng0625 commented Oct 18, 2024

✨ Description

Add MaskGCT

🚧 Related Issues

[List the issue numbers related to this PR]

πŸ‘¨β€πŸ’» Changes Proposed

  • Add MaskGCT (inference, demo, ckpt)
  • Add codec related to MaskGCT

πŸ§‘β€πŸ€β€πŸ§‘ Who Can Review?

@jiaqili3 @RMSnow @yuantuo666

πŸ›  TODO

  • Add MaskGCT/Codec code
  • Add gradio demo
  • Update README
  • Add ckpt

βœ… Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

Copy link
Collaborator

@jiaqili3 jiaqili3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@yuantuo666
Copy link
Collaborator

yuantuo666 commented Oct 19, 2024

@HeCheng0625 Thanks for your great work. How about adding a section in README to introduce the dataset used to train MaskGCT?

== Updated ==
I've already added this in the README.md

Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RMSnow RMSnow merged commit bc1fe8a into open-mmlab:main Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants