Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: SingVisio citation, resources links, and Emilia TODOs #274

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

yuantuo666
Copy link
Collaborator

✨ Description

Update: SingVisio citations and resources links

🚧 Related Issues

None

πŸ‘¨β€πŸ’» Changes Proposed

  • SingVisio README.md: citations and links.
  • Amphion README.md: citations and links.

πŸ§‘β€πŸ€β€πŸ§‘ Who Can Review?

@lmxue @RMSnow

πŸ›  TODO

None

βœ… Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

README.md Show resolved Hide resolved
egs/visualization/SingVisio/README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the information mentioned in the comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
egs/visualization/SingVisio/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yuantuo666 yuantuo666 changed the title Update: SingVisio citations and resources links Update: SingVisio citation, resources links, and Emilia TODOs Sep 23, 2024
Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
P.S.: It would be better to submit one PR per task.

@yuantuo666
Copy link
Collaborator Author

@RMSnow All comments resolved. Please review the requested changes so that PR can proceed. Thanks!

@RMSnow RMSnow merged commit d9243b8 into open-mmlab:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants